Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caliper modifier #11

Closed
wants to merge 41 commits into from
Closed

Caliper modifier #11

wants to merge 41 commits into from

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Sep 11, 2023

[[DO NOT MERGE]] This commit provides a draft implementation of the caliper modifier for benchpark

@rfhaque rfhaque requested review from pearce8 and becker33 September 11, 2023 22:54
@pearce8 pearce8 added the feature New feature or request label Oct 17, 2023
papi:
externals:
- spec: [email protected]
prefix: /opt/cray/pe/papi/7.0.0.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@becker33 @scheibelp Should we be looking for a system install of PAPI, or is it advisable to build PAPI for each system?

buildable: false
elfutils:
externals:
- spec: [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@becker33 @scheibelp Same question for elf

configs/cts1/auxiliary_software_files/packages.yaml Outdated Show resolved Hide resolved
modifiers:
- name: caliper
mode: spot
success_criteria:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque Do we have to have a success criteria, even if we use the output of this modifier only in post-processing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque Do we have to have a success criteria, even if we use the output of this modifier only in post-processing?

@pearce8 We still need some way to assess the success/failure of the experiment using "ramble workspace analyze". We use the modifier output in post-processing to extract the FOM and use that in the success criteria.

@pearce8 pearce8 marked this pull request as draft November 7, 2023 14:25
@github-actions github-actions bot added experiment New or modified experiment configs New or modified system config application New or modified application labels Jan 12, 2024
@rfhaque
Copy link
Collaborator Author

rfhaque commented Apr 3, 2024

@pearce8 Closing this PR as the top-down and cuda modifier implementations have been split into their own branches

@rfhaque rfhaque closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application New or modified application configs New or modified system config experiment New or modified experiment feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants