-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caliper modifier #11
Caliper modifier #11
Conversation
papi: | ||
externals: | ||
- spec: [email protected] | ||
prefix: /opt/cray/pe/papi/7.0.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@becker33 @scheibelp Should we be looking for a system install of PAPI, or is it advisable to build PAPI for each system?
buildable: false | ||
elfutils: | ||
externals: | ||
- spec: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@becker33 @scheibelp Same question for elf
modifiers: | ||
- name: caliper | ||
mode: spot | ||
success_criteria: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfhaque Do we have to have a success criteria, even if we use the output of this modifier only in post-processing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfhaque Do we have to have a success criteria, even if we use the output of this modifier only in post-processing?
@pearce8 We still need some way to assess the success/failure of the experiment using "ramble workspace analyze". We use the modifier output in post-processing to extract the FOM and use that in the success criteria.
@pearce8 Closing this PR as the top-down and cuda modifier implementations have been split into their own branches |
[[DO NOT MERGE]] This commit provides a draft implementation of the caliper modifier for benchpark