Replace swagger-based QA client with simple fetch calls #3342
+268
−2,301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlittman
force-pushed
the
t3262-swagger
branch
from
70ec7b4 to
b3553a0
Compare
ndushay
approved these changes
Nov 18, 2021
| * for each type are different, so check the nonldLookup field in the lookup config. | ||
| * If the field is not set, assume false. | ||
| * There are four types of lookup: linked data and non-linked data, authority | ||
| * andsubauthority. The API calls for each type are different, so construct |
| }) | ||
| }) | ||
|
|
||
| describe("when non-LD authority", () => { |
There was a problem hiding this comment.
should there be a test with subauthority for this one? You mention 4 types in the class comments, so ... four cases in the test??
There was a problem hiding this comment.
This actually is an authority with subauthority. In addition, all of our non-LD authorities have subauthorities.
Made this clearer in test.
Fixes #3262 This commit replaces the swagger-based QA client. Why? 1. the API specification is incomplete; 2. it's not clear there is a plan in place to keep the specification up to date; and 3. we only use a fraction of the QA API in the Sinopia editor In short, it's to pay down technical debt. This commit otherwise retains the same interface for interacting with the QA API, returning a promise that resolves to the HTTP response.
justinlittman
force-pushed
the
t3262-swagger
branch
from
b3553a0 to
05c8ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3262
This commit replaces the swagger-based QA client. Why?
In short, it's to pay down technical debt. This commit otherwise retains the same interface for interacting with the QA API, returning a promise that resolves to the HTTP response.
Why was this change made?
This is an update on @mjgiarlo's earlier PR.
How was this change tested?
Which documentation and/or configurations were updated?