-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking NN including labels #13
Conversation
without auto formatting
if (alg == NN) | ||
{ | ||
// Assign maximum cost if observations and trajectories labelled do not match | ||
if (m_observations[i].tag != m_filters[j].tag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that whenever NN
is used, the tag checking will be employed, right? That's a change to the default behaviour that present to date. I think, it should be an optional behaviour. I suggest to actually implement this as another association algorithm, e.g. NN_TAGGED
or NN_LABELED
and making sure the original one is left as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Yeah, I can change that. My thinking behind combining them was that if a label is provided then it is used to help distinguish them, but if a label is not provided then it is assigned an empty string, which when compared, will match and have no affect. The only time this will ever differ from the original is when a label is provided but you don't want them to be further distinguished by it. Would this ever be something that you would want? |
Restored default behaviour implimented another association algorithm
Don't merge this yet. I've noticed some errors which need correcting first. |
That passed my tests, but needs to be checked 😄 |
retest this please |
closes #12 @marc-hanheide can you merge this? |
Adds Maximum cost to labels which do not match.