Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensemble support in reader and support for groups in Netcdfwriter #802

Closed
wants to merge 10 commits into from
+372 −106
Closed

Ensemble support in reader and support for groups in Netcdfwriter #802

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a456bb2
Fix bug in support for reading groups
kwrobot Oct 28, 2024
b2ab429
Add support for ensembles to reader
kwrobot Oct 28, 2024
01a21b8
Initial support for variables in groups in write: move them to root
kwrobot Oct 28, 2024
dce83cb
First attempt to write groups.
kwrobot Oct 22, 2024
527ccfe
First seemingly working version.
kwrobot Nov 13, 2024
7de03ab
Cleanup: Removing debug code and consolidate defining and writing coo…
kwrobot Nov 23, 2024
5bb2867
Make handling of ensemble dimension more in line with other dimensions
kwrobot Dec 3, 2024
6474015
Added comments for clarification.
kwrobot Dec 4, 2024
4f0f37a
Do not write have_ensemble_dim attribute to file.
kwrobot Dec 4, 2024
7c664b0
Added/updated tests for groups/ensembles
kwrobot Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion io/teca_array_collection_reader.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ teca_metadata teca_array_collection_reader::get_output_metadata(unsigned int por
std::string name;
teca_metadata atts;
if (teca_netcdf_util::read_variable_attributes(fh, "", i,
"", "", "", t_axis_variable, 0, name, atts))
"", "", "", t_axis_variable, "", 0, name, atts))
{
this->clear_cached_metadata();
TECA_FATAL_ERROR("Failed to read " << i <<"th variable attributes")
Expand Down
Loading