Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding extra documentation to parser_xml.py #593

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Adding extra documentation to parser_xml.py #593

wants to merge 1 commit into from

Conversation

elbashandy
Copy link
Contributor

No description provided.

@elbashandy elbashandy requested review from burlen and taobrienlbl April 6, 2021 02:08
taobrienlbl
taobrienlbl requested changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@taobrienlbl taobrienlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in person today: the added docstrings are great. This PR should also include comments on the main code (e.g., avoid having long blocks of code w/o comments).

@elbashandy elbashandy force-pushed the issue-585-parse_xml-doc branch from c4d2278 to 56d8418 Compare May 3, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taobrienlbl taobrienlbl taobrienlbl requested changes

@burlen burlen Awaiting requested review from burlen

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elbashandy @taobrienlbl