Start: UX refinements

Start: Automatically run command when event loop starts
Also sets PartDesign as the default startup Workbench.
Start: Add checkbox for starting or not starting Start
Start: Correct default card size parameter access
Start: General cleanup

src/Main/MainGui.cpp

@@ -164,7 +164,7 @@ int main( int argc, char ** argv )
     App::Application::Config()["AppIcon"] = "freecad";
     App::Application::Config()["SplashScreen"] = "freecadsplash";
     App::Application::Config()["AboutImage"] = "freecadabout";
-    App::Application::Config()["StartWorkbench"] = "NoneWorkbench";
+    App::Application::Config()["StartWorkbench"] = "PartDesignWorkbench";
     //App::Application::Config()["HiddenDockWindow"] = "Property editor";
     App::Application::Config()["SplashAlignment" ] = "Bottom|Left";
     App::Application::Config()["SplashTextColor" ] = "#8aadf4"; // light blue

src/Mod/Start/CMakeLists.txt

@@ -21,6 +21,10 @@
 #  *                                                                          *
 #  ***************************************************************************/
 
+if( NOT EXISTS "${CMAKE_SOURCE_DIR}/src/3rdParty/GSL" )
+        message( SEND_ERROR "The C++ Guidelines Support Library (GSL) submodule is not available. Please run git submodule update --init" )
+endif()
+
 add_subdirectory(App)
 
 set(Start_Scripts

src/Mod/Start/Gui/AppStartGui.cpp

@@ -22,13 +22,17 @@
  ***************************************************************************/
 
 #include "PreCompiled.h"
+#ifndef _PreComp_
+#include <QString>
+#include <QTimer>
+#endif
 
 #include <Base/Console.h>
 #include <Base/Interpreter.h>
 #include <Base/PyObjectBase.h>
 #include <Gui/Language/Translator.h>
+#include <Gui/Command.h>
 
-#include <QString>
 
 #include <3rdParty/GSL/include/gsl/pointers>
 
@@ -60,6 +64,28 @@ class Module: public Py::ExtensionModule<Module>
     }
 };
 
+class StartLauncher
+{
+public:
+    StartLauncher()
+    {
+        // QTimers don't fire until the event loop starts, which is our signal that the GUI is up
+        QTimer::singleShot(1000, [this] {
+            Launch();
+        });
+    }
+
+    void Launch()
+    {
+        auto hGrp = App::GetApplication().GetParameterGroupByPath(
+            "User parameter:BaseApp/Preferences/Mod/Start");
+        bool showOnStartup = hGrp->GetBool("ShowOnStartup", true);
+        if (showOnStartup) {
+            Gui::Application::Instance->commandManager().runCommandByName("Start_Start");
+        }
+    }
+};
+
 PyObject* initModule()
 {
     auto newModule = gsl::owner<Module*>(new Module);
@@ -71,6 +97,8 @@ PyObject* initModule()
 /* Python entry */
 PyMOD_INIT_FUNC(StartGui)
 {
+    static StartGui::StartLauncher* launcher = new StartGui::StartLauncher();
+
     Base::Console().Log("Loading GUI of Start module... ");
     PyObject* mod = StartGui::initModule();
     auto manipulator = std::make_shared<StartGui::Manipulator>();

src/Mod/Start/Gui/CMakeLists.txt

@@ -62,7 +62,8 @@ SET(StartGui_SRCS
         )
 
 SET(StartGuiIcon_SVG
-        Resources/icons/StartWorkbench.svg
+        Resources/icons/StartCommandIcon.svg
+        Resources/icons/PartDesignWorkbench.svg
         )
 
 # TODO: Evaluate PCH use with Qt6/QtQuick/Qml

src/Mod/Start/Gui/FileCardDelegate.cpp

@@ -55,7 +55,7 @@ void FileCardDelegate::paint(QPainter* painter,
                              const QModelIndex& index) const
 {
     auto thumbnailSize =
-        static_cast<int>(_parameterGroup->GetInt("FileThumbnailIconsSize", 64));  // NOLINT
+        static_cast<int>(_parameterGroup->GetInt("FileThumbnailIconsSize", 128));  // NOLINT
     auto cardWidth = thumbnailSize;
     auto baseName = index.data(static_cast<int>(DisplayedFilesModelRoles::baseName)).toString();
     auto size = index.data(static_cast<int>(DisplayedFilesModelRoles::size)).toString();
@@ -126,16 +126,14 @@ QPixmap pixmapToSizedQImage(const QImage& pixmap, int size)
 QPixmap FileCardDelegate::generateThumbnail(const QString& path) const
 {
     auto thumbnailSize =
-        static_cast<int>(_parameterGroup->GetInt("FileThumbnailIconsSize", 64));  // NOLINT
+        static_cast<int>(_parameterGroup->GetInt("FileThumbnailIconsSize", 128));  // NOLINT
     if (path.endsWith(QLatin1String(".fcstd"), Qt::CaseSensitivity::CaseInsensitive)) {
         QImageReader reader(QLatin1String(":/icons/freecad-doc.svg"));
-        ;
         reader.setScaledSize({thumbnailSize, thumbnailSize});
         return QPixmap::fromImage(reader.read());
     }
     if (path.endsWith(QLatin1String(".fcmacro"), Qt::CaseSensitivity::CaseInsensitive)) {
         QImageReader reader(QLatin1String(":/icons/MacroEditor.svg"));
-        ;
         reader.setScaledSize({thumbnailSize, thumbnailSize});
         return QPixmap::fromImage(reader.read());
     }

src/Mod/Start/Gui/Manipulator.cpp

@@ -49,7 +49,7 @@ CmdStart::CmdStart()
     sToolTipText = QT_TR_NOOP("Displays the Start in an MDI view");
     sWhatsThis = "Start_Start";
     sStatusTip = sToolTipText;
-    sPixmap = "StartWorkbench";
+    sPixmap = "StartCommandIcon";
 }
 
 void CmdStart::activated(int iMsg)

src/Mod/Start/Gui/PreCompiled.h

@@ -43,6 +43,7 @@
 #include <unordered_map>
 
 // Qt
+#include <QCheckBox>
 #include <QCoreApplication>
 #include <QFile>
 #include <QFileIconProvider>
@@ -56,7 +57,9 @@
 #include <QPushButton>
 #include <QScrollArea>
 #include <QSpacerItem>
+#include <QString>
 #include <QStyleOptionViewItem>
+#include <QTimer>
 #include <QUrl>
 #include <QVBoxLayout>
 #include <QWidget>

src/Mod/Start/Gui/Resources/Start.qrc

@@ -1,5 +1,6 @@
 <RCC>
     <qresource prefix="/">
-        <file>icons/StartWorkbench.svg</file>
+        <file>icons/StartCommandIcon.svg</file>
+        <file>icons/PartDesignWorkbench.svg</file>
     </qresource>
 </RCC>