chore: replace direct 'go' command with '$(GO)' variable #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Makefile and go.mk to use '$(GO)' instead of 'go' - This change allows for easier Go version management and flexibility - Affects build, test, lint, and other Go-related commands Using a variable for the Go command simplifies version management and ensures consistency across different environments.
elliotxx
changed the title
- Update github.com/bytedance/mockey to v1.2.13 - Update github.com/gopherjs/gopherjs to v1.17.2 - Update github.com/smartystreets/assertions to v1.16.0 - Update github.com/smartystreets/goconvey to v1.8.1 - Update golang.org/x/arch to v0.12.0 - Update golang.org/x/sys to v0.28.0 These updates ensure compatibility and security improvements. test: ensure proper cleanup of mocks in certgenerator tests - Add `mockey.UnPatchAll()` at the start of each test case - Ensure mocks are properly cleaned up after each test This change prevents mock interference between test cases, improving test reliability.
- Add 'github.com/swaggo/http-swagger/v2' and 'golang.org/x/sync' as direct dependencies - Remove 'github.com/swaggo/http-swagger/v2' from indirect dependencies - Correct a typo in the 'golang.org/x/tools' comment These changes ensure the project uses the latest versions of necessary libraries and corrects a minor documentation error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind chore
What this PR does / why we need it:
This PR replaces direct usage of the 'go' command with the '$(GO)' variable in the Makefile and go.mk files.
Key changes include:
Usage (modify go.mk#L5):
v1.2.10tov1.2.13, fix errorlink: github.com/bytedance/mockey/internal/monkey/common: invalid reference to runtime.sysAllocOSWhich issue(s) this PR fixes:
Fixes #697