Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix secret labels typo "labesl" #100

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

wujunwei
Copy link
Contributor

fix typo : secret label bug

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

charts/charts/karpor/templates/karpor-server.yml:19

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

bug fix

apiVersion: v1
kind: Secret
metadata:
  name: karpor-auth
  namespace: {{ .Values.namespace }}
  labesl: {{- include "karpor.labels" (dict "context" . "component" .Values.server.name) | nindent 4 }}

The label field is wrong, and the label of the Secret control through Values.yaml ​​will not take effect!

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link
Contributor

github-actions bot commented Jan 24, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@wujunwei
Copy link
Contributor Author

wujunwei commented Jan 24, 2025

I have read the CLA Document and I hereby sign the CLA

@wujunwei
Copy link
Contributor Author

recheck

@wujunwei wujunwei changed the title Update karpor-server.yml fix secret labels typo "labesl" Jan 24, 2025
@elliotxx
Copy link
Collaborator

elliotxx commented Jan 24, 2025

@wujunwei Nice catch! But you also need to update the version of Helm Chart (0.7.0 -> 0.7.1), because the Chart template has changed

@wujunwei
Copy link
Contributor Author

@wujunwei Nice catch! But you also need to update the version of Helm Chart (0.7.0 -> 0.7.1), because the Chart template has changed

Done :)

Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 56b0666 into KusionStack:master Jan 24, 2025
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
@elliotxx
Copy link
Collaborator

@wujunwei Welcome! KusionStack/karpor#761

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants