Merge pull request #37 from KumarLabJax/fix-corner-features

Fix corner features
KumarLabJax · May 6, 2024 · 202cc44 · 202cc44
2 parents 913a063 + e3ef844
commit 202cc44
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/feature_extraction/features.py b/src/feature_extraction/features.py
@@ -15,7 +15,7 @@
 from .segmentation_features import SegmentationFeatureGroup
 
 
-FEATURE_VERSION = 7
+FEATURE_VERSION = 8
 
 _FEATURE_MODULES = [
     BaseFeatureGroup,

diff --git a/src/feature_extraction/landmark_features/corner.py b/src/feature_extraction/landmark_features/corner.py
@@ -47,6 +47,10 @@ def get_distances(self, identity: int) -> typing.Tuple[np.ndarray, np.ndarray]:
             except KeyError:
                 return distances, bearings
 
+            # points and convex hulls are in y,x 
+            # corners are x,y so flip them to match points and convex hulls
+            corners = np.flip(corners, axis=-1)
+
             for frame in range(self._poses.num_frames):
 
                 # don't scale the point coordinates by the pixel_scale value,