-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement #474 and add a 'multitool' item type #681
Open
AnAwesomGuy
wants to merge
7
commits into
KubeJS-Mods:1902
Choose a base branch
from
AnAwesomGuy:474_multitool
base: 1902
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnAwesomGuy
changed the title
Implement #474 and add a 'multitool
Implement #474 and add a 'multitool' item type
Aug 1, 2023
dunno how to do this w/o pr so whatever
ChiefArug
reviewed
Aug 4, 2023
common/src/main/java/dev/latvian/mods/kubejs/item/custom/MultitoolItemJS.java
Outdated
Show resolved
Hide resolved
common/src/main/java/dev/latvian/mods/kubejs/item/custom/MultitoolItemJS.java
Show resolved
Hide resolved
common/src/main/java/dev/latvian/mods/kubejs/item/custom/MultitoolItemJS.java
Outdated
Show resolved
Hide resolved
fabric/src/main/java/dev/latvian/mods/kubejs/fabric/BuiltinKubeJSFabricPlugin.java
Outdated
Show resolved
Hide resolved
Another thing to consider is Forges ToolAction system. It would require a subclass for Forge tho. |
i think its good now! |
ChiefArug
reviewed
Aug 31, 2023
common/src/main/java/dev/latvian/mods/kubejs/item/custom/MultitoolItemJS.java
Show resolved
Hide resolved
common/src/main/java/dev/latvian/mods/kubejs/item/custom/MultitoolItemJS.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #474 and adds a new item type,
'multitool'
. To create a multitool, set the item type to'multitool'
and use.tool(toolName)
to add a tool to the multitool. Valid tool types include: 'axe', 'hoe', 'pickaxe', and 'shovel'.Example Script