#7 - Added option to allow searching with offset and set limit of items re… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turned. Also refactored to create searchService
Closed
-required to allow reviewer to test branch locally-
SuhaybY
approved these changes
Jan 12, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…turned. Also refactored to create searchService
Why
As discussed in issue #7 this pr will allow the user the api to search with an offset. Since spotify by default only returns back only 20 items at a time, this pr will fix the issue of getting results past the 20 returned. In addition this pr has added limit option - up to 50 items can be returned at a time! Also refactored out the searchTrack function as it was doing too many things. We now follow how authentication works.
What
Refactored searchTrack to be like authenticate - creating a new searchService.
Added limit and offset option for search feature.