Remove inheritance of built-in column types, improve readability of column type classes, fix getters that returns columns from data tables #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
setName
,setOptions
andsetOption
methods in column builder.FormColumnType
.DateColumnType
no longer usesDateTimeColumnType
as its parentDatePeriodColumnType
no longer usesDateTimeColumnType
as its parentDateTimeColumnType
no longer usesTextColumnType
as its parentEnumColumnType
no longer usesTextColumnType
as its parentLinkColumnType
no longer usesTextColumnType
as its parentLinkColumnType
no longer usesTextColumnType
as its parentMoneyColumnType
no longer usesNumberColumnType
as its parentNumberColumnType
no longer usesTextColumnType
as its parentTherefore, every built-in column type is using base
ColumnType
as its parent. This fixes an issue where creating type extension for one type (e.g.TextColumnType
) was incorrectly affecting other built-in types, without a way to prevent that.Now, for example, if you want to create a column type extension for both
TextColumnType
andNumberColumnType
, provide both of those types from the extension'sgetExtendedTypes()
method.Changes
getColumns
,getVisibleColumns
,getHiddenColumns
andgetExportableColumns
methods fromDataTable
class returning columns in incorrect order and visibility when using personalization