Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coorection to GetLowerSpan method in nurbs_utilitites #13096

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

NickNick9
Copy link
Contributor

📝 Description

This PR improves the GetLowerSpan function in NurbsUtilities by adding a correction mechanism for ParameterT to ensure numerical robustness. The enhancement helps handle cases where ParameterT is very close to a knot, avoiding potential floating-point precision issues.

@NickNick9 NickNick9 requested a review from a team as a code owner February 5, 2025 10:33
rubenzorrilla
rubenzorrilla previously approved these changes Feb 5, 2025
Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for me. Not sure at all, but maybe you want to throw a warning message if this happens.

@rickyaristio
Copy link
Contributor

Nice catch! Could you provide one in the test when we need the floating point tolerance?

@NickNick9
Copy link
Contributor Author

@rubenzorrilla
We prefer not to throw a warning every time this happens because in large simulations it may occur frequently.

@rickyaristio
Nice suggestion! We created a test as you said. Now is ready to be merged.

@rubenzorrilla
Copy link
Member

@rubenzorrilla We prefer not to throw a warning every time this happens because in large simulations it may occur frequently.

Fair enough.

@NickNick9
Copy link
Contributor Author

@rickyaristio, could you approve the merge? Thanks!

@NickNick9 NickNick9 merged commit 6e3a039 into master Feb 6, 2025
11 checks passed
@NickNick9 NickNick9 deleted the PR_nurbs_utilities branch February 6, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants