Pr small brep surface new constructor #13094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rubenzorrilla This is the part you asked to modify in order to avoid passing ModelParts in the constructor of the geometry. We really need to merge this to go on with the other PRs. |
|
@rubenzorrilla |
kratos/geometries/brep_surface.h
Outdated
| */ | ||
| GeometrySurrogateArrayType& GetSurrogateInnerLoopGeometries() | ||
| { | ||
| return mpSurrogateInnerLoopGeometries; |
There was a problem hiding this comment.
Suggested change
| return mpSurrogateInnerLoopGeometries; | |
| return mrSurrogateInnerLoopGeometries; |
kratos/geometries/brep_surface.h
Outdated
| */ | ||
| GeometrySurrogateArrayType& GetSurrogateOuterLoopGeometries() | ||
| { | ||
| return mpSurrogateOuterLoopGeometries; |
There was a problem hiding this comment.
Suggested change
| return mpSurrogateOuterLoopGeometries; | |
| return mrSurrogateOuterLoopGeometries; |
Co-authored-by: Nicolò Antonelli <[email protected]>
kratos/geometries/brep_surface.h
Outdated
Comment on lines
167
to
168
| mpSurrogateInnerLoopGeometries = rOther.GetSurrogateInnerLoopGeometries(); | ||
| mpSurrogateOuterLoopGeometries = rOther.GetSurrogateOuterLoopGeometries(); |
There was a problem hiding this comment.
Suggested change
| mpSurrogateInnerLoopGeometries = rOther.GetSurrogateInnerLoopGeometries(); | |
| mpSurrogateOuterLoopGeometries = rOther.GetSurrogateOuterLoopGeometries(); | |
| mpSurrogateInnerLoopGeometries = rOther.mpSurrogateInnerLoopGeometries; | |
| mpSurrogateOuterLoopGeometries = rOther.mpSurrogateOuterLoopGeometries; |
kratos/geometries/brep_surface.h
Outdated
Comment on lines
182
to
183
| mpSurrogateInnerLoopGeometries = rOther.GetSurrogateInnerLoopGeometries(); | ||
| mpSurrogateOuterLoopGeometries = rOther.GetSurrogateOuterLoopGeometries(); |
There was a problem hiding this comment.
Suggested change
| mpSurrogateInnerLoopGeometries = rOther.GetSurrogateInnerLoopGeometries(); | |
| mpSurrogateOuterLoopGeometries = rOther.GetSurrogateOuterLoopGeometries(); | |
| mpSurrogateInnerLoopGeometries = rOther.mpSurrogateInnerLoopGeometries; | |
| mpSurrogateOuterLoopGeometries = rOther.mpSurrogateOuterLoopGeometries; |
| auto p_surface = GenerateReferenceNodeSurfaceHalfCirclePointer(); | ||
|
|
||
| using BrepSurfaceType = BrepSurface<PointerVector<Node>, true, PointerVector<Point>>; | ||
| using BrepCurveOnSurfaceType = BrepCurveOnSurface<PointerVector<Node>, true, PointerVector<Point>>; |
There was a problem hiding this comment.
Suggested change
| using BrepCurveOnSurfaceType = BrepCurveOnSurface<PointerVector<Node>, true, PointerVector<Point>>; | |
| using BrepCurveOnSurfaceType = typename BrepSurfaceType::BrepCurveOnSurfaceType; |
There was a problem hiding this comment.
If we eventually change the type in BrepSurfaceType this will automatically handle it.
|
|
||
| using BrepSurfaceType = BrepSurface<PointerVector<Node>, true, PointerVector<Point>>; | ||
| using BrepCurveOnSurfaceType = BrepCurveOnSurface<PointerVector<Node>, true, PointerVector<Point>>; | ||
| using BrepCurveOnSurfaceLoopArrayType = DenseVector<DenseVector<typename BrepCurveOnSurfaceType::Pointer>>; |
There was a problem hiding this comment.
Suggested change
| using BrepCurveOnSurfaceLoopArrayType = DenseVector<DenseVector<typename BrepCurveOnSurfaceType::Pointer>>; | |
| using BrepCurveOnSurfaceLoopArrayType = typename BrepSurfaceType::BrepCurveOnSurfaceLoopArrayType; |
| auto p_surface = GenerateReferenceNodeSurfaceHalfCirclePointer(); | ||
|
|
||
| using BrepSurfaceType = BrepSurface<PointerVector<Node>, true, PointerVector<Point>>; | ||
| using BrepCurveOnSurfaceType = BrepCurveOnSurface<PointerVector<Node>, true, PointerVector<Point>>; |
There was a problem hiding this comment.
If we eventually change the type in BrepSurfaceType this will automatically handle it.
|
|
||
| using BrepSurfaceType = BrepSurface<PointerVector<Node>, true, PointerVector<Point>>; | ||
| using BrepCurveOnSurfaceType = BrepCurveOnSurface<PointerVector<Node>, true, PointerVector<Point>>; | ||
| using BrepCurveOnSurfaceLoopArrayType = DenseVector<DenseVector<typename BrepCurveOnSurfaceType::Pointer>>; |
rubenzorrilla
previously approved these changes
Feb 10, 2025
rubenzorrilla
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding a constructor to the BrepSurface class (brep_surface.h) for use in SBM applications.
Please mark the PR with appropriate tags:
🆕 Changelog