Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsApplication] Fix performance difference between line-based and interface-based piping elements #13091

Merged
merged 4 commits into from
Feb 5, 2025
Merged

[GeoMechanicsApplication] Fix performance difference between line-based and interface-based piping elements #13091

merged 4 commits into from
Feb 5, 2025

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Feb 4, 2025

No description provided.

@rfaasse rfaasse linked an issue Feb 4, 2025 that may be closed by this pull request
[GeoMechanicsApplication] Investigate performance of 'new' piping element #13092
Closed
@rfaasse rfaasse requested a review from avdg81 February 4, 2025 13:02
avdg81
avdg81 reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing this clear fix with a unit test. I have two minor suggestions, nothing blocking.

applications/GeoMechanicsApplication/custom_elements/geo_steady_state_Pw_piping_element.h Outdated Show resolved Hide resolved
...anicsApplication/tests/cpp_tests/custom_elements/test_geo_steady_state_Pw_piping_element.cpp Outdated Show resolved Hide resolved
rfaasse
rfaasse commented Feb 4, 2025
View reviewed changes
Copy link
Contributor Author

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review, processed your suggestions!

applications/GeoMechanicsApplication/custom_elements/geo_steady_state_Pw_piping_element.h Outdated Show resolved Hide resolved
...anicsApplication/tests/cpp_tests/custom_elements/test_geo_steady_state_Pw_piping_element.cpp Outdated Show resolved Hide resolved
avdg81
avdg81 previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks ready to go for me.

@rfaasse rfaasse requested a review from avdg81 February 5, 2025 06:49
avdg81
avdg81 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks ready to be merged to me.

@rfaasse rfaasse merged commit ab54c55 into master Feb 5, 2025
11 checks passed
@rfaasse rfaasse deleted the geo/fix-performance-difference-between-piping-elements branch February 5, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdg81 avdg81 avdg81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Investigate performance of 'new' piping element
2 participants
@rfaasse @avdg81