Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][FastPR] Quick fix for incorrect parameters in the Tesselate function #13083

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

rickyaristio
Copy link
Contributor

📝 Description
This fast PR fixes the wrong parameters order in the Tesselate function.

@rickyaristio rickyaristio added Kratos Core FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Feb 2, 2025
@rickyaristio rickyaristio requested a review from a team February 2, 2025 18:06
@rickyaristio rickyaristio requested a review from a team as a code owner February 2, 2025 18:06
@rubenzorrilla
Copy link
Member

Shouldn't the test values change?

@rickyaristio
Copy link
Contributor Author

Shouldn't the test values change?

The one that will be affected by this change is the computation of tessellation in brep trimming utilities. There is no test yet in the master branch, which will be provided after #13080.

This compute tessellation remains unaffected.

Copy link
Contributor

@juancamarotti juancamarotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me 👍

@rubenzorrilla
Copy link
Member

Shouldn't the test values change?

The one that will be affected by this change is the computation of tessellation in brep trimming utilities. There is no test yet in the master branch, which will be provided after #13080.

This compute tessellation remains unaffected.

OK (provided that the test is added in that upcoming PR).

@juancamarotti juancamarotti self-requested a review February 3, 2025 16:25
@juancamarotti juancamarotti merged commit 7c2d526 into master Feb 3, 2025
11 checks passed
@juancamarotti juancamarotti deleted the core/fix_curve_tessellation branch February 3, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CAD Integration FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants