Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] New compilation options #11790
[CORE] New compilation options #11790
Changes from all commits
68b89bd
37f66cf
013300a
6a8ac3c
f7c8a94
a9a8be4
357deb2
88895b8
58ca747
b9cbba6
adb3e4f
d7a16fc
64feea2
c705c92
c79e98a
67e8f33
5c0cb50
3a816e0
7e78719
b3fdd0c
c5044f8
541baf6
4aceed0
e3fad41
e9a9214
d252771
6df0752
5291a13
e8eef78
3713f82
66c0544
0a718a8
6241d19
3b41796
afcbd7d
c142012
ecd01c4
67f1859
5601a47
17432c1
1f7abfa
321b0d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt this be in dependencies?
configure_core.sh
is a bit misleading otherwiseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.. I agree, but for reasons I need those three to be compiled in the first stage no matter what, otherwise the list of dependencies and when to activate them becomes a mess. I may change the name of the script to relfect that :S
(bascially moving trilinos and linear solvers retriggers the compilation of the core no matter what, so ....)