Removal of counters in Kotlin Channels #4302
Draft
+143
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behaviour
The earlier implementation relied on counters to track the number of pointers referencing each node. When a pointer moved to the next node, the counter on the current node was decremented, and the counter on the next node was incremented. A node was marked as logically removed (and then subject to physical removal) when its counter was equal to 0, indicating no active pointers.
New behaviour
The new implementation does not use counters anymore. When the pointer is moved to the next node, no further action is needed to maintain a consistent state of the list. The removal process does not depend on the position of pointers; instead, after the physical removal happened and if there are any pointers on the removed node, they are moved forward to the first alive node or the tail if such node does not exist.
cleanPrev()invocationsTODO