Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of DispatchException in an undispatched case #4272

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Improve handling of DispatchException in an undispatched case #4272

wants to merge 3 commits into from

Conversation

qwwdfsad
Copy link
Contributor

No description provided.

@qwwdfsad
Properly rename test that is responsible for fast-path failing for un…
7c27e87 
…dispatched mode
@qwwdfsad
Simplify, document and reduce the binary size of Undispatched.kt
9e1fa64
@qwwdfsad
Rethrow dispatcher exceptions during the undispatched coroutines star…
f8503e4 
…t immediately

Otherwise, in the face of malfunctioning dispatcher, there might be no trace of any error, making it extremely hard to debug.

The root cause should be addressed by #4209

Fixes #4142
@qwwdfsad qwwdfsad changed the title Dispatch exception path Improve handling of DispatchException in an undispatched case Nov 11, 2024
@qwwdfsad
Copy link
Contributor Author

qwwdfsad commented Nov 11, 2024 •
edited
Loading

Looking at #4209 (comment), I have yet to see an elegant, generalized solution to our problem that is neither a breaking change nor an obvious contract breach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb Awaiting requested review from dkhalanskyjb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@qwwdfsad