Upgrade to Kotlin 2.1.0 #475
Draft
+188
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
kotlin-2.1.0
branch
from
1adc04a to
7757d36
Compare
whyoleg
reviewed
Jan 23, 2025
core/build.gradle.kts
Outdated
| sourceSets { | ||
| groupSourceSets("linux", listOf("linuxX64", "linuxArm64", "linuxArm32Hfp")) |
There was a problem hiding this comment.
just in case: probably it could be easier to use KGP hierarchy API for this: example from kotlinx.atomicfu, example from ktor
There was a problem hiding this comment.
Thanks! I didn't know about this functionality. Unfortunately, this PR can't use this to its full extent, as in this Kotlin version, wasmJs and wasmWasi were not in the hierarchy templates.
Opened a competing PR using this approach: #477
There was a problem hiding this comment.
I was wrong. After clearing all caches, wasmJs and wasmWasi are actually present.
* Avoid using deprecated API when grouping source sets together * Do not explicitly set `metaInfo = true` for NPM, it's the default * Upgrade the Yarn lock file
dkhalanskyjb
force-pushed
the
kotlin-2.1.0
branch
from
7757d36 to
07ce67c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metaInfo = truefor NPM, it's the default