Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test suite for PostgreSQL local tests with covering case with URLs #798

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

zaleslaw
Copy link
Collaborator

@zaleslaw zaleslaw commented Jul 30, 2024

Refactored PostgresTest for modular, reusable test data setup and introduced PostgresConnectionUrlTest to validate different PostgreSQL connection URLs. These changes improve test readability and ensure comprehensive URL configurations handling.

Fixes #497

@koperagen could you please take a look at the ticket #497 probably you faced with the case, when it was failed
I've combined URLs with login/password and with other GET parameters

Refactored `PostgresTest` for modular, reusable test data setup and introduced `PostgresConnectionUrlTest` to validate different PostgreSQL connection URLs. These changes improve test readability and ensure comprehensive URL configurations handling.
@zaleslaw zaleslaw requested a review from koperagen July 30, 2024 13:40
@zaleslaw
Copy link
Collaborator Author

zaleslaw commented Aug 7, 2024

check for plugins and schema generation, dataframe.read(URL)

@zaleslaw zaleslaw merged commit 4cc6429 into master Sep 3, 2024
6 checks passed
@zaleslaw zaleslaw removed the request for review from koperagen September 3, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support URL links with parameters for reading DataFrame from the SQL database
1 participant