Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert go-database-reconciler to 1.16.1 and go-kong to 0.60.0 #6822

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Dec 12, 2024

What this PR does / why we need it:

Passing enterprise-postgres against 3.9.0.0-rc.5 with go-kong 0.60.0: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12293996547/job/34308934489

Which issue this PR fixes:

Related: #6823

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added this to the KIC v3.4.x milestone Dec 12, 2024
@pmalek pmalek changed the title revert GDR to 1.16.1 and go-kong to 0.60.0 chore: revert go-database-reconciler to 1.16.1 and go-kong to 0.60.0 Dec 12, 2024
@pmalek pmalek force-pushed the revert-go-kong-to-0-60 branch from cb8e218 to 0368208 Compare December 12, 2024 10:58
@pmalek
Copy link
Member Author

pmalek commented Dec 12, 2024

Started validation pipeline against 3.9.0.0-rc.5 once again in https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12295001082

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.3%. Comparing base (93856b1) to head (0368208).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6822     +/-   ##
=======================================
- Coverage   79.1%   77.3%   -1.9%     
=======================================
  Files        209     209             
  Lines      25149   25153      +4     
=======================================
- Hits       19915   19456    -459     
- Misses      4219    4699    +480     
+ Partials    1015     998     -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek marked this pull request as ready for review December 12, 2024 12:04
@pmalek pmalek requested a review from a team as a code owner December 12, 2024 12:04
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, in order to unlock the process of both KIC and Gateway

@pmalek pmalek merged commit 9247df3 into main Dec 12, 2024
140 checks passed
@pmalek pmalek deleted the revert-go-kong-to-0-60 branch December 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants