Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add -cluster-ca-key-type and -cluster-ca-key-size flags to control the type and size (for rsa) of CA private keys #1081

Merged
merged 11 commits into from
Jan 23, 2025
Merged

feat: add -cluster-ca-key-type and -cluster-ca-key-size flags to control the type and size (for rsa) of CA private keys #1081

merged 11 commits into from
Jan 23, 2025

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jan 23, 2025 •
edited
Loading

What this PR does / why we need it:

Add -cluster-ca-key-type and -cluster-ca-key-size flags to allow configuring which private key types to use for cluster CA.

Allowed values: rsa and ecdsa (default, remains as it was).

Which issue this PR fixes

Fixes #

Internal reference: FTI-6433

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek added the area/feature New feature or request label Jan 23, 2025
@pmalek pmalek added this to the KGO v1.5.x milestone Jan 23, 2025
@pmalek pmalek self-assigned this Jan 23, 2025
@pmalek pmalek force-pushed the add-cluster-ca-key-type branch 3 times, most recently from 241d5ec to 4dcc406 Compare January 23, 2025 11:44
@pmalek pmalek marked this pull request as ready for review January 23, 2025 12:00
@pmalek pmalek requested a review from a team as a code owner January 23, 2025 12:00
@pmalek pmalek changed the title feat: add -cluster-ca-key-type and -cluster-ca-key-size flags to control the type and size (for rsa) of CA private keys feat: add -cluster-ca-key-type and -cluster-ca-key-size flags to control the type and size (for rsa) of CA private keys Jan 23, 2025
czeslavo
czeslavo reviewed Jan 23, 2025
View reviewed changes
controller/pkg/secrets/privkey_test.go Outdated Show resolved Hide resolved
controller/pkg/secrets/privkey_test.go Outdated Show resolved Hide resolved
controller/controlplane/controller_reconciler_utils.go Outdated Show resolved Hide resolved
controller/controlplane/controller_reconciler_utils.go Outdated Show resolved Hide resolved
controller/dataplane/bluegreen_controller.go Outdated Show resolved Hide resolved
controller/dataplane/controller.go Outdated Show resolved Hide resolved
controller/dataplane/owned_resources.go Outdated Show resolved Hide resolved
controller/pkg/secrets/cert.go Outdated Show resolved Hide resolved
modules/manager/config/types.go Outdated Show resolved Hide resolved
modules/manager/controller_setup.go Outdated Show resolved Hide resolved
@pmalek pmalek force-pushed the add-cluster-ca-key-type branch from 4dcc406 to c03968e Compare January 23, 2025 13:05
@pmalek pmalek requested a review from czeslavo January 23, 2025 13:57
@pmalek pmalek enabled auto-merge January 23, 2025 14:14
@pmalek pmalek added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 3607dde Jan 23, 2025
26 checks passed
@pmalek pmalek deleted the add-cluster-ca-key-type branch January 23, 2025 14:39
@pmalek pmalek linked an issue Jan 28, 2025 that may be closed by this pull request
Support for Custom CA with RSA Keys #994
Closed
4 tasks
@pmalek pmalek mentioned this pull request Jan 28, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czeslavo czeslavo czeslavo approved these changes

Assignees

@pmalek pmalek

Labels
area/feature New feature or request
Projects
None yet
Milestone
KGO v1.5.x
Development

Successfully merging this pull request may close these issues.

Support for Custom CA with RSA Keys
2 participants
@pmalek @czeslavo