Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versioning issues with OAS and insomnia buttons #8418

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Feb 10, 2025

Description

Fixing two issues with our Gateway Admin EE and OSS specs:

  1. The version number in the specs for 3.9 and latest is incorrect, both should be 3.9 but are showing 3.8. The content of the files are correct for 3.9 though, I tracked down the file histories and it just looks like the version number update was missed.
  2. The insomnia buttons to the versioned specs are incorrect. Easiest solution, added a shortcode that we can access via {{page.short_version}}.

Specs are already updated in Konnect Dev Portal.

Tested the buttons, they all import the correct specs. Note that the filename format changed in 3.8, so that's why I had to version tag the URLs.

Issue reported on Slack.

Testing instructions

Preview link:

Checklist

@lena-larionova lena-larionova added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Feb 10, 2025
@lena-larionova lena-larionova requested a review from a team as a code owner February 10, 2025 18:24
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 43be293
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/67aa47fbd7d7740008c293f7
😎 Deploy Preview https://deploy-preview-8418--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 91 (🔴 down 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mheap
Copy link
Member

mheap commented Feb 10, 2025

You can dynamically add the short version entry if you prefer

e.g.

@page.data['major_minor_version'] = release.value.gsub('.x', '').gsub('.', '')

@lena-larionova
Copy link
Contributor Author

You can dynamically add the short version entry if you prefer

e.g.

@page.data['major_minor_version'] = release.value.gsub('.x', '').gsub('.', '')

❗ Didn't know this existed; couldn't find it it in the versions file. Good thing this didn't take me very long 😄 I'll replace with that.

@mheap mheap merged commit 98b02c0 into main Feb 10, 2025
16 checks passed
@mheap mheap deleted the fix/insomnia-buttons branch February 10, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants