Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom-dns.md #8400

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Update custom-dns.md #8400

merged 2 commits into from
Jan 31, 2025

Conversation

josh-konghq
Copy link
Contributor

Updating Serverless for CAA instructions

Description

Updated the Serverless custom domains doc to include instructions on adding CAA to prevent CAA errors with Serverless GWs.

Testing instructions

Preview link:

Checklist

Updating Serverless for CAA instructions
@josh-konghq josh-konghq added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Jan 31, 2025
@josh-konghq josh-konghq requested a review from a team as a code owner January 31, 2025 18:40
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 7ebb064
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/679d35dde06f830008d462f3
😎 Deploy Preview https://deploy-preview-8400--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 92 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudjumpercat
Copy link
Contributor

Verified that the link flagged in the broken link checker works, so manually passing the link checker.

Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making these updates!

@cloudjumpercat cloudjumpercat merged commit 5f29432 into main Jan 31, 2025
34 of 36 checks passed
@cloudjumpercat cloudjumpercat deleted the josh-konghq-patch-2 branch January 31, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:manual-approve:link-validation review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants