-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update custom-dns.md #8400
Merged
Merged
Update custom-dns.md #8400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Serverless for CAA instructions
josh-konghq
added
the
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
label
Jan 31, 2025
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cloudjumpercat
added
ci:manual-approve:link-validation
and removed
ci:manual-approve:link-validation
labels
Jan 31, 2025
Verified that the link flagged in the broken link checker works, so manually passing the link checker. |
cloudjumpercat
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making these updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:manual-approve:link-validation
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Serverless for CAA instructions
Description
Updated the Serverless custom domains doc to include instructions on adding CAA to prevent CAA errors with Serverless GWs.
Testing instructions
Preview link:
Checklist