-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes reference #617
Conversation
Signed-off-by: Diana <[email protected]>
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Diana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't much to review here IMO, we just need this page to exist.
It feels like the content on that page should be on the plugins?
I agree, I would add a todo to that page to remind whoever takes that page on to add that info.
Is there a way (and should we) remove all the headers except the ## [version number] breaking changes headers so it's easier to navigate to the version you need?
I think we should. Especially since all of the sections aren't uniform. Personally, I would bold those headers and create a post migration ticket to make these entry uniform if it all possible. There may be a @fabianrbz solution here. I would tag him in it and if there is nothing let's just merge this tomorrow morning.
I can't think of anything other than |
Signed-off-by: Diana <[email protected]>
Signed-off-by: Diana <[email protected]>
Description
Fixes #549
Preview Links
https://deploy-preview-617--kongdeveloper.netlify.app/gateway/breaking-changes/
Questions for reviewers
## [version number] breaking changes
headers so it's easier to navigate to the version you need?Stub pages created:
Post GA issue to fix headers:
#631
Checklist