Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Admin API landing page + security reference #542

Merged
merged 7 commits into from
Feb 28, 2025
Merged

Feat: Admin API landing page + security reference #542

merged 7 commits into from
Feb 28, 2025

Conversation

lmilan
Copy link
Contributor

@lmilan lmilan commented Feb 28, 2025 •
edited
Loading

Description

Fixes #369

Preview Links

Checklist

  • Every page is page one.
  • Tested how-to docs. If not, note why here.
  • All pages contain metadata.
  • Updated sources.yaml. For more info, review track docs changes
  • Any new docs link to existing docs.
  • All autogenerated instructions render correctly (API, decK, Konnect, Kong Manager).
  • Style guide (capitalized gateway entities, placeholder URLs) implemented correctly.

@lmilan lmilan self-assigned this Feb 28, 2025
@lmilan lmilan linked an issue Feb 28, 2025 that may be closed by this pull request
Admin API reference page #369
Closed
@netlify Netlify
Copy link

netlify bot commented Feb 28, 2025 •
edited
Loading

✅ Deploy Preview for kongdeveloper ready!

Name Link
🔨 Latest commit 290b024
🔍 Latest deploy log https://app.netlify.com/sites/kongdeveloper/deploys/67c1e6c4b3f22d00082da091
😎 Deploy Preview https://deploy-preview-542--kongdeveloper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lmilan lmilan force-pushed the 369-admin-api-reference-page branch from d7b8643 to d18b9bb Compare February 28, 2025 13:46
@lmilan lmilan marked this pull request as ready for review February 28, 2025 13:54
@lmilan lmilan requested a review from a team as a code owner February 28, 2025 13:54
Guaris
Guaris requested changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@Guaris Guaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch the deck examples to use
{% entity_example %} ?

Other than that, I think we can shelve the secure the admin API doc for now. Can you make a ticket to revisit this post migration?

@lmilan lmilan force-pushed the 369-admin-api-reference-page branch from 09a291d to 290b024 Compare February 28, 2025 16:39
@Guaris Guaris self-requested a review February 28, 2025 17:24
@lmilan lmilan merged commit 81fc420 into main Feb 28, 2025
10 checks passed
@lmilan lmilan deleted the 369-admin-api-reference-page branch February 28, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guaris Guaris Guaris approved these changes

Assignees

@lmilan lmilan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin API reference page
2 participants
@lmilan @Guaris