Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Review #295

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Entity Review #295

wants to merge 12 commits into from

Conversation

mheap
Copy link
Member

@mheap mheap commented Jan 21, 2025

Description

I've reviewed all core Gateway entities. It's awesome to see so much information in one place.

Thoughts for the future if y'all agree:

  • Admin/RBAC endpoints aren't entities imo. We should have a dedicated admin authentication space for Gateway that's separate from entities. I'd include event_hooks here too
  • I didn't review the Plugin entity. That's a much bigger job for the future. We need to cover plugins holistically, including plugin phases etc.
  • There seems to be some confusion about related pages e.g. the LDAP plugin being linked from the Groups entity. We have a lot of similar, but different topics. We need to be vigilant that the linked content is actually related rather than just sounding related.

Fixes #239
Fixes #240

Checklist

  • Every page is page one.
  • Tested how-to docs. If not, note why here. - Only looked at entities
  • All pages contain metadata.
  • Updated sources.yaml. For more info, review track docs changes - N/A
  • Any new docs link to existing docs.
  • All autogenerated instructions render correctly (API, decK, Konnect, Kong Manager).
  • Style guide (capitalized gateway entities, placeholder URLs) implemented correctly.

@mheap mheap requested a review from a team as a code owner January 21, 2025 18:01
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for kongdeveloper ready!

Name Link
🔨 Latest commit eedf73c
🔍 Latest deploy log https://app.netlify.com/sites/kongdeveloper/deploys/679110406bb034000877d09f
😎 Deploy Preview https://deploy-preview-295--kongdeveloper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mheap mheap changed the title Service + Route updates Entity Review Jan 22, 2025
@mheap mheap force-pushed the core-entity-updates branch from 6a5ca8c to eedf73c Compare January 22, 2025 15:35
@lena-larionova lena-larionova self-requested a review January 22, 2025 16:14
@lena-larionova lena-larionova self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy reference migration Load balancing reference and how-tos
2 participants