Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env variables section to Vault entity page #284

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Add env variables section to Vault entity page #284

merged 3 commits into from
Jan 22, 2025

Conversation

cloudjumpercat
Copy link
Contributor

@cloudjumpercat cloudjumpercat commented Jan 17, 2025 •
edited
Loading

Description

Fixes #234

Preview Links

https://deploy-preview-284--kongdeveloper.netlify.app/gateway/entities/vault/#store-secrets-as-environment-variables

Checklist

  • Every page is page one.
  • Tested how-to docs. If not, note why here. I tested the snippets I added
  • All pages contain metadata.
  • Updated sources.yaml. For more info, review track docs changes
  • Any new docs link to existing docs.
  • All autogenerated instructions render correctly (API, decK, Konnect, Kong Manager).
  • Style guide (capitalized gateway entities, placeholder URLs) implemented correctly.

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for kongdeveloper ready!

Name Link
🔨 Latest commit 7558108
🔍 Latest deploy log https://app.netlify.com/sites/kongdeveloper/deploys/67911193e8bff300082aabfd
😎 Deploy Preview https://deploy-preview-284--kongdeveloper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudjumpercat cloudjumpercat marked this pull request as ready for review January 17, 2025 22:14
@cloudjumpercat cloudjumpercat requested a review from a team as a code owner January 17, 2025 22:14
@lmilan lmilan self-requested a review January 21, 2025 15:11
lmilan
lmilan reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@lmilan lmilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm just wondering if the schema should stay above the setup for consistency with other entities

@cloudjumpercat
Copy link
Contributor Author

Looks good! I'm just wondering if the schema should stay above the setup for consistency with other entities

@lmilan I'll move it back to match the other entities for consistency.

@cloudjumpercat cloudjumpercat merged commit 3de447d into main Jan 22, 2025
10 checks passed
@cloudjumpercat cloudjumpercat deleted the env-variable-vault branch January 22, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmilan lmilan lmilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store secrets as environment variables
2 participants
@cloudjumpercat @lmilan