Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Killing Vertx Server on failure and ability to use Pipeline + InferenceConfiguration JSON as cli (start and build) input config #453

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Killing Vertx Server on failure and ability to use Pipeline + InferenceConfiguration JSON as cli (start and build) input config #453

merged 4 commits into from
Aug 11, 2020

Conversation

ShamsUlAzeem
Copy link
Contributor

@ShamsUlAzeem ShamsUlAzeem commented Jul 9, 2020 •
edited
Loading

Fixing #384, #386 and #446

@ShamsUlAzeem ShamsUlAzeem changed the title Killing Vertx Server on failure and ability to use Pipeline JSON as cli input config. Killing Vertx Server on failure and ability to use Pipeline JSON as cli (start and build) input config. Jul 9, 2020
@ShamsUlAzeem ShamsUlAzeem changed the title Killing Vertx Server on failure and ability to use Pipeline JSON as cli (start and build) input config. Killing Vertx Server on failure and ability to use Pipeline JSON as cli (start and build) input config [WIP] Jul 9, 2020
@ShamsUlAzeem ShamsUlAzeem self-assigned this Jul 9, 2020
@ShamsUlAzeem ShamsUlAzeem changed the title Killing Vertx Server on failure and ability to use Pipeline JSON as cli (start and build) input config [WIP] Killing Vertx Server on failure and ability to use Pipeline + InferenceConfiguration JSON as cli (start and build) input config [WIP] Jul 9, 2020
@ShamsUlAzeem ShamsUlAzeem requested a review from AlexDBlack July 12, 2020 23:45
@ShamsUlAzeem ShamsUlAzeem changed the title Killing Vertx Server on failure and ability to use Pipeline + InferenceConfiguration JSON as cli (start and build) input config [WIP] Killing Vertx Server on failure and ability to use Pipeline + InferenceConfiguration JSON as cli (start and build) input config Jul 12, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

29.5% 29.5% Coverage
15.1% 15.1% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@agibsonccc agibsonccc merged commit 927cb13 into master Aug 11, 2020
@agibsonccc agibsonccc deleted the sa/stop-server-on-fail branch August 11, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexDBlack AlexDBlack Awaiting requested review from AlexDBlack

Assignees

@ShamsUlAzeem ShamsUlAzeem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShamsUlAzeem @agibsonccc