forked from jl777/komodo
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.8.2 [Smaug] #611
Merged
0.8.2 [Smaug] #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without -fPIC for libcryptoconditions_core.a build will end with error below on Xenial: ``` /usr/bin/ld: cryptoconditions/libcryptoconditions_core.a(libcryptoconditions_core_a-cryptoconditions.o): relocation R_X86_64_32 against `.text' can not be used when making a shared object; recompile with -fPIC cryptoconditions/libcryptoconditions_core.a: error adding symbols: Bad value collect2: error: ld returned 1 exit status ```
Co-authored-by: Jack Grigg <[email protected]> Co-authored-by: Kris Nuttycombe <[email protected]> Co-authored-by: Daira Hopwood <[email protected]>
burned coins refer to the value sent for OP_RETURN scripts: ``` "vout": [ ... { "value": 2.00000000, "valueZat": 200000000, "n": 1, "scriptPubKey": { "asm": "OP_RETURN 6465636b6572", "hex": "6a066465636b6572", "type": "nulldata" } } ], "vjoinsplit": [ ] ``` burned coins are also excluded from transparent pool.
this update activates burned coins value pool, see: BURNED_VALUE_VERSION
The change was made solely for debugging purposes and was accidentally included in the PR. We are now reverting that change.
get rid of using THC chain name in ParseArgumentsTests
Pass CWalletDB to OrderedTxItems() as optional param
build: fix build on xenial (16.04)
add chain supply, transparent and burned coins value pools
update assetchains.{json,old} to actual version
DeckerSU
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump version 0.8.2 [smaug]
DeckerSU
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.