-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transaction-history): incorrect transaction history shown when switching coins #2525
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Empty transaction histories appear to step directly into the onDone handler, skipping the listener handler entirely. Adding this event shows the "No transaction history" message when there is no transaction history present for the coin
47fdc21
to
5727a86
Compare
Visit the preview URL for this PR (updated for commit 4abd876): https://walletrc--pull-2525-merge-2tr84mkm.web.app (expires Tue, 18 Feb 2025 20:36:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
onError and onDone can be called after another for the same stream (almost like try-catch-finally)
Fixes two bugs when switching between coins to view transaction histories:
onDone
handler without adding an event or emitting a state, soloading
stayed true.In addition:
sequential
todroppable
, to drop any new events that occur while a balance refresh is already running. This also prevents requests from piling up and infinitely requesting wallet balance updates