feat(swap): implement 0 dexfee for kmd trading pairs #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borngraced
changed the title
borngraced
changed the title
onur-ozkan
reviewed
Feb 5, 2025
Comment on lines
+5894
to
+5898
| let fee_coin = match &self.coin_type { | ||
| EthCoinType::Eth => self.ticker.to_owned(), | ||
| EthCoinType::Erc20 { platform, .. } => platform.to_owned(), | ||
| EthCoinType::Nft { .. } => return MmError::err(TradePreimageError::NftProtocolNotSupported), | ||
| }; |
There was a problem hiding this comment.
You can use platform_ticker instead. I am not sure if you intentionally drop the nft support, but if we want to do that we need to add a if check before using platform_ticker.
Comment on lines
+3684
to
+3685
| /// Check and return true if DexFee is not required to trade otherwise return false. | ||
| pub fn no_fee(&self) -> bool { matches!(self, Self::Zero) } |
There was a problem hiding this comment.
Suggested change
| /// Check and return true if DexFee is not required to trade otherwise return false. | |
| pub fn no_fee(&self) -> bool { matches!(self, Self::Zero) } | |
| /// Check and return true if DexFee is not required to trade otherwise return false. | |
| pub fn zero_fee(&self) -> bool { matches!(self, Self::Zero) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2321