SwapFeeManager contract for managing Dex and Burn Fees #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/SwapFeeManagerTest.js
Outdated
Comment on lines
41
to
42
| expect(finalDexFeeBalance - initialDexFeeBalance).to.equal(ethers.parseEther("0.75")); | ||
| expect(finalBurnFeeBalance - initialBurnFeeBalance).to.equal(ethers.parseEther("0.25")); |
There was a problem hiding this comment.
ummmm, why are we checking the balance difference and not just the new balance?
There was a problem hiding this comment.
Before each test we get a set of default hardhat accounts, which have non-zero eth balances
when you run tests, these accounts persist their state (including balance) across tests in the same testing session.
Initial ETH Dex Fee Wallet Balance: 10000000000000000000000
Initial ETH Burn Fee Wallet Balance: 10000000000000000000000
Final ETH Dex Fee Wallet Balance: 10000750000000000000000
Final ETH Burn Fee Wallet Balance: 10000250000000000000000
✔ should correctly split and withdraw Ether fees (61ms)
Initial ERC20 Dex Fee Wallet Balance: 0
Initial ERC20 Burn Fee Wallet Balance: 0
Initial ETH Dex Fee Wallet Balance: 10000750000000000000000
Initial ETH Burn Fee Wallet Balance: 10000250000000000000000
Final ERC20 Dex Fee Wallet Balance: 750000000000000000
Final ERC20 Burn Fee Wallet Balance: 250000000000000000
✔ should correctly split and withdraw ERC20 token fees (113ms)
As for Erc20 token, in log we see 0, as we dont transfer tokens manually to account as in these for example from EtomicSwapTakerV2.js
etomic-swap/test/EtomicSwapTakerV2Test.js
Line 67 in 9881905
well, I can set balance to 0 with hardhat rpc 2af148a
contracts/SwapFeeManager.sol
Outdated
| uint256 totalBalance = address(this).balance; | ||
| require(totalBalance > 0, "No fees to split"); | ||
|
|
||
| uint256 burnFeeAmount = (totalBalance * 25) / 100; |
There was a problem hiding this comment.
can we set these percentages as const?
There was a problem hiding this comment.
yep we can, as constants are fixed at compile-time it doesnt increase gas usage 2af148a
laruh
force-pushed
the
fee_manager_contract
branch
from
4c0f115 to
2af148a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SwapFeeManagercontract handles the management and distribution of Dex and burn fees. Key features include:Fee Distribution:
dexFeeWallet.burnFeeWallet.Ether Management:
splitAndWithdrawfunction splits and transfers the Ether to the designated wallets.ERC20 Token Management:
splitAndWithdrawTokenfunction, which similarly splits and transfers the token balance.Access Control:
Event Logging:
FeesSplitevent whenever fees are split and distributed.