Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniprot sourcename fix #108

Merged
merged 11 commits into from
Feb 8, 2024
Merged

Uniprot sourcename fix #108

merged 11 commits into from
Feb 8, 2024

Conversation

bsantan
Copy link
Collaborator

@bsantan bsantan commented Feb 7, 2024

  • Fix in merge.yaml to look in uniprot_genome_features for transformed files
  • Fix in uniprot.py to us Uniprot prefix in protein IDs rather than uniprot_genome_features prefix

…der. Update subtring in nodes and edges file to Uniprot prefix.
@hrshdhgd
Copy link
Contributor

hrshdhgd commented Feb 7, 2024

Instead of hardcoding strings I'd recommend using constants.py to declare as a variable first and then use it in the project

@bsantan
Copy link
Collaborator Author

bsantan commented Feb 7, 2024

I added constants to the uniprot.py file rather than strings.

@bsantan bsantan requested a review from hrshdhgd February 8, 2024 16:05
Copy link
Contributor

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's push to merge #107 first and then we can merge this one. I have a suspicion there will be conflicts with this branch that'll need manual intervention. But we'll deal with it when we get there. Undo the changes you made in tox.ini. #107 seems to have been fixed. So once we merge down the main branch to this one, all should be fine!

@hrshdhgd hrshdhgd merged commit 41dda3c into master Feb 8, 2024
3 checks passed
@hrshdhgd hrshdhgd deleted the uniprot_sourcename_issue branch February 8, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants