-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniprot sourcename fix #108
Conversation
bsantan
commented
Feb 7, 2024
- Fix in merge.yaml to look in uniprot_genome_features for transformed files
- Fix in uniprot.py to us Uniprot prefix in protein IDs rather than uniprot_genome_features prefix
…der. Update subtring in nodes and edges file to Uniprot prefix.
Instead of hardcoding strings I'd recommend using constants.py to declare as a variable first and then use it in the project |
I added constants to the uniprot.py file rather than strings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's push to merge #107 first and then we can merge this one. I have a suspicion there will be conflicts with this branch that'll need manual intervention. But we'll deal with it when we get there. Undo the changes you made in tox.ini
. #107 seems to have been fixed. So once we merge down the main branch to this one, all should be fine!