Created Piece model #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM, however might you want to add |
|
Hi Jacob, Zayn and I are sharing the task 😊 |
|
Looks good! |
|
@zaynrahn one small thing for later (which is a little different here since you're sharing a task), but the person who opened the PR should be the one to eventually click merge, just in case something breaks, that way you as a reviewer don't have to end up debugging somebody else's code in that case. But no worries here 👍 |
|
@jacobwgillespie oops, sorry =( |
|
No worries at all, just less you have to worry about as a PR reviewer in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.