Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TrameApp): Support decorated class inheritance #679

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

finetjul
Copy link
Member

@finetjul finetjul commented Feb 3, 2025

Support class inheritance for decorated classes.

@finetjul finetjul requested a review from jourdain February 3, 2025 23:22
@finetjul finetjul force-pushed the trameapp-support-inheritance branch 2 times, most recently from 0b50c62 to b96b983 Compare February 3, 2025 23:24
@finetjul finetjul force-pushed the trameapp-support-inheritance branch from b96b983 to fd5c97e Compare February 3, 2025 23:28
@jourdain
Copy link
Collaborator

jourdain commented Feb 4, 2025

Did you see that #594 ?

@finetjul
Copy link
Member Author

finetjul commented Feb 4, 2025

Did you see that #594 ?

No I did not.

My PR does not fix the type(t) usage.
The best would probably to "patch" the __init__() method of the to-wrap class. Not sure how to do it.

@finetjul
Copy link
Member Author

finetjul commented Feb 4, 2025

Did you see that #594 ?

No I did not.

My PR does not fix the type(t) usage. The best would probably to "patch" the __init__() method of the to-wrap class. Not sure how to do it.

I modified my PR to avoid intermediate class injection...

@jourdain jourdain merged commit 1af1fd8 into Kitware:master Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants