SealedBidTokenSale

[ylv-io]

Description

Type of change

• Bug fix
• New feature
• Breaking change
• Dependency changes
• Deployment
• Forge Script
• Code refactor / cleanup
• Documentation or wording changes
• Other

Checklist:

• The diff is legible and has no extraneous changes
• Complex code has been commented, including external interfaces
• Tests have 100% code coverage
• The base branch is either main, or there's a description of how to merge

Issue Resolution

[openzeppelin-code]

SealedBidTokenSale

Generated at commit: f135245c149c9cdee6c4fef033e74f29af426538

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	4 2 0 12 39 57
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[github-actions]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

• unchecked-transfer (1 results) (High)

unchecked-transfer

Impact: High
Confidence: Medium

• ID-0
  AaveWithdrawWorkflow.withdraw(address,uint256) ignores return value by IERC20(asset).transfer(safe,fee)

kinto-core/src/access/workflows/AaveWithdrawWorkflow.sol

Lines 50 to 64 in 401d556

	function withdraw(address asset, uint256 amount) public returns (uint256) {
	address pool = poolAddressProvider.getPool();
	// If amount is max uint256, withdraw all available
	if (amount == type(uint256).max) {
	amount = IERC20(IAavePool(pool).getReserveData(asset).aTokenAddress).balanceOf(address(this));
	}
	// Withdraw from Aave
	IAavePool(pool).withdraw(asset, amount, address(this));
	// Send the fee to the Safe
	uint256 fee = amount * FEE / 1e18;
	IERC20(asset).transfer(safe, fee);
	return amount - fee;
	}

[codecov]

Codecov Report

Attention: Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (d1e5236) to head (f135245).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/apps/SealedBidTokenSale.sol	98.70%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   88.83%   89.11%   +0.28%     
==========================================
  Files          41       42       +1     
  Lines        2579     2656      +77     
==========================================
+ Hits         2291     2367      +76     
- Misses        288      289       +1     

Files with missing lines	Coverage Δ
src/apps/SealedBidTokenSale.sol	98.70% <98.70%> (ø)