Fall back to on-caller-thread execution on failure to create threads #20
+18
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing around with exa on wasi, I ran into the following problem:
So I made some small changes to be able to use scoped_threadpool on platforms without threads.
That being said, I'm unsure whether doing this is a good idea. There doesn't seem to be a good way to know whether thread creation failed due to a platform limitation or other reasons (I refuse to parse error messsage strings), and this is semantically a breaking change, since the spawned tasks may wait for some action on the main thread inside the Scope, which may never occur if the no-thread fallback is activated.
If you have any opinions on this, I'd love to hear them. Accept? Hide behind a feature or target_os gate? Better ideas? Better not?