Fix build script. Worked on MacOS but broke windows

.github/workflows/build_desktop.yml

@@ -21,9 +21,8 @@ jobs:
 
       - run: pip install -r requirements.txt
 
-      - run: sh ./desktop/build_desktop_app.sh
-      # MacOS apps have symlinks, and the artifact upload zip will break them. Tar instead.
-      - run: cd desktop/build/dist && tar czpvf fune.app.tgz fune.app && rm -r fune.app && echo "Ready to upload"
+      # Compress MacOS app param ignored on Windows
+      - run: sh ./desktop/build_desktop_app.sh --compress-mac-app
       - uses: actions/upload-artifact@v4
         with:
           name: fune-desktop-${{ runner.os }}-${{ runner.arch }}

desktop/README.md

@@ -0,0 +1,10 @@
+# MacOS Code Signing
+
+How to sign on of the builds from GitHub Actions for offical release.
+
+Easy way, but just signs with personal ID, not developer ID: `codesign --force --deep -s - fune.app`
+
+Proper way with a developer ID:
+
+1. Get developer ID name: `security find-identity -v -p codesigning`
+2. Run `codesign --force --deep -s "Developer ID Application: YOUR NAME (XXXXXXXX)" fune.app`

desktop/build_desktop_app.sh

@@ -42,3 +42,12 @@ pyinstaller --windowed $(printf %s "$PLATFORM_OPTS") --icon="./icon.png" \
   --noconfirm --distpath=./desktop/build/dist --workpath=./desktop/build/work \
   -n fune --specpath=./desktop/build \
   --paths=. ./desktop/desktop.py
+
+# MacOS apps have symlinks, and GitHub artifact upload zip will break them. Tar instead.
+if [[ $* == *--compress-mac-app* && "$(uname)" == "Darwin" ]]; then
+  echo "Compressing MacOS app"
+  cd ./desktop/build/dist
+  tar czpvf fune.app.tgz fune.app
+  rm -r fune.app
+  cd ../../..
+fi