Another fix for MacOS checksums. Checksum before deleting the dir, an…

…d move the tar process into github action
Kiln-AI · Mar 1, 2025 · 5d888b6 · 5d888b6
1 parent 33159b1
commit 5d888b6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/build_desktop.yml b/.github/workflows/build_desktop.yml
@@ -39,7 +39,7 @@ jobs:
 
       # Compress MacOS app param ignored on other platforms
       - name: Build Desktop App
-        run: uv run bash ./app/desktop/build_desktop_app.sh --compress-mac-app
+        run: uv run bash ./app/desktop/build_desktop_app.sh
 
       - name: Build Windows Installer
         if: matrix.os == 'windows-latest'
@@ -55,7 +55,7 @@ jobs:
 
       - name: Checksums (macOS)
         if: runner.os == 'macOS'
-        run: find ./app/desktop/build/dist/Kiln.app ! -iname "./app/desktop/build/dist/Kiln.app/Contents/Resources/botocore/data/*" -type f -exec md5 {} \;
+        run: find ./app/desktop/build/dist/Kiln.app -type f -not -path "*/Contents/Resources/botocore/data/*" -exec md5 {} \;
 
       - name: Checksums (Linux)
         if: runner.os == 'Linux'
@@ -67,6 +67,15 @@ jobs:
           certutil -hashfile ./app/desktop/build/dist/Kiln.Windows.Installer.exe SHA256
           certutil -hashfile ./app/desktop/build/dist/Kiln/Kiln.exe SHA256
 
+      # MacOS apps have symlinks, and GitHub artifact upload zip will break them. Tar instead.
+      - name: Compress MacOS App
+        if: runner.os == 'macOS'
+        working-directory: ./app/desktop/build/dist
+        run: |
+          echo "Compressing MacOS app"
+          tar czpvf Kiln.app.tgz Kiln.app
+          rm -r Kiln.app
+
       - name: Upload Build
         uses: actions/upload-artifact@v4
         with:

diff --git a/app/desktop/build_desktop_app.sh b/app/desktop/build_desktop_app.sh
@@ -68,12 +68,3 @@ pyinstaller $(printf %s "$PLATFORM_OPTS")  \
   --noconfirm --distpath=./desktop/build/dist --workpath=./desktop/build/work \
   -n Kiln --specpath=./desktop/build \
   --paths=. ./desktop/desktop.py
-
-# MacOS apps have symlinks, and GitHub artifact upload zip will break them. Tar instead.
-if [[ $* == *--compress-mac-app* && "$(uname)" == "Darwin" ]]; then
-  echo "Compressing MacOS app"
-  cd ./desktop/build/dist
-  tar czpvf Kiln.app.tgz Kiln.app
-  rm -r Kiln.app
-  cd ../../..
-fi