[FEATURE] Save files back to server #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(later, I'll change this to work outside of the editor as well)
Cleaning up little by little. trying to better follow [johnpapa's angular styleguide](https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md)
Since require caches requests, we get the same json for the life of the server. but we want to get the updated settings on each refresh
yess!!!!! for some reason the ruler is the only thing that doesn't work..... hmmmmm
now, coded on kibibit :-)
thatkookooguy
added this to the 01. Create a kickass **code editor** for remote programming milestone
| vm.projectFolderPath = ''; | ||
| sessionStorage.projectFolderPath = vm.projectFolderPath; | ||
| vm.openFile = ''; | ||
| } |
| '<p class=\'prompt\'>\' | / | : | ; |.\'; ; ; |.\'; ; : : |-, : | \\ | : | : ;_ | | \'</p>' + | ||
| '<p class=\'prompt\'>| ; ; \' \' ; `----\' | | `----\' | | : | ;/| | : \' \'; | \\ \\ `. \' : |</p>' + | ||
| '<p class=\'prompt\'>: \' \\ | | | \' : ; \' : ; | : .\' \' \' ;. ; `----. \\ ; | ;</p>' + | ||
| '<p class=\'prompt\'>\' : |. \\ | | \' \' : | \' : | \' : ;/| \' : | ; .\' / /`--\' / `--..`; </p>' + |
There was a problem hiding this comment.
Line must be at most 80 characters
There was a problem hiding this comment.
Line must be at most 80 characters
neilkalman-redkix
force-pushed
the
feature-save-to-server
branch
from
3b4b859 to
8696f7b
Compare
| @@ -98,7 +98,7 @@ angular.module('kibibitCodeEditor') | |||
| setTimeout(function() { | |||
| var gif; | |||
|
|
|||
| $.get('http://api.giphy.com/v1/gifs/random?api_key=dc6zaTOxFJmzC&tag=kittens', function(result) { | |||
| $.get('//api.giphy.com/v1/gifs/random?api_key=dc6zaTOxFJmzC&tag=kittens', function(result) { | |||
There was a problem hiding this comment.
Line must be at most 80 characters
This will allow us to replace the sessionStorage later if needed.
|
|
||
| .factory('SessionStorageService', ['$window', function($window) { | ||
| return $window.sessionStorage; | ||
| }]); |
| @@ -0,0 +1,5 @@ | |||
| md-toast { | |||
There was a problem hiding this comment.
Files should end with a trailing newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
FUCKING SAVE FILES!!!! [resolves SAVE EXISTING FILES #144]
FUCKING SAVE & LOAD SETTINGS!!! [resolves Settings Feature #83]
sessionStoragecodeEditor.jsto better follow johnpapa's angular styleguideMore info
how exciting! 😁
Before you submit a PR, make sure you did the following things: