[FEATURE] Save files back to server #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add material icons
## summary * code editor component gets the selected file path, get it's content and update the view * file tree component gets the folder path, load the folder structure and update the tree * main controller now acts as a "bridge" between the file tree and code editor components
* trailing white spaces deletion * multiple var declaration fix
* merged two duplicate selectors to 1 in scss
will make things more specific later using some rules from the https://github.com/agis-/git-style-guide/blob/master/README.md
Currently, the `style.scss` file contains all of our override styles. we need to move this to another file to have the lint disabled for those only. The only thing we need to disable globally later is the `NestingDepth` and `SelectorDepth` rules
fix loading bar styling and disable some lint rules
made `isFullscreen` part of the init of the settings + made the button toggle that setting.
toggle material icon with isFullscreen setting
Cleaning up little by little. trying to better follow [johnpapa's angular styleguide](https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md)
|
|
||
| settingsService.put = function(req, res) { | ||
| if (req.body.newContent) { | ||
| fs.writeFile(settingsLocation, JSON.stringify(req.body.newContent, null, 2), 'utf8', function(err) { |
There was a problem hiding this comment.
Line must be at most 80 characters
Since require caches requests, we get the same json for the life of the server. but we want to get the updated settings on each refresh
yess!!!!! for some reason the ruler is the only thing that doesn't work..... hmmmmm
| settings.init = function(savedSettings) { | ||
| cursor = savedSettings.cursor || {row: '0', column: '0'}; | ||
| editorSettings.init(savedSettings.editorSettings); | ||
| } |
now, coded on kibibit :-)
[BUG] Make arrow clickable in file tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
FUCKING SAVE FILES!!!! [resolves SAVE EXISTING FILES #144]
FUCKING SAVE & LOAD SETTINGS!!! [resolves Settings Feature #83]
codeEditor.jsto better follow johnpapa's angular styleguideMore info
how exciting! 😁
Before you submit a PR, make sure you did the following things: