Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add project avatar #116

Closed
wants to merge 5 commits into from
Closed

Conversation

thatkookooguy
Copy link
Member

Change Summary

  • Add project avatar to the menu bar [ resolves Add circular logo for projects #114 ]

    should work like this:

    1. placeholder of kibibit if no project is open
    2. project logo if a .logo.png file is included in the same path as package.json (will be supported once we parse some project details on the server)
    3. show a folder icon if a folder is selected that doesn't have a package.json file + .logo.png file to read
  • did you link this PR to an issue?

  • did you lint your changes to both javascript and scss?

  • "I'm pretty sure I'll be able to read and understand this PR, even if I wasn't the author." - _said the PR author_


This change is Reviewable

add a circular project avatar.

should work like this:
1. placeholder of kibibit if no project is open
2. project logo if a .logo.png file is included in the same path as package.json (will be supported once we parse some project details on the server)
3. show a folder icon if a folder that doesn't have a package.json file to read
@thatkookooguy thatkookooguy temporarily deployed to kibibit-demo-pr-116 April 21, 2016 14:49 Inactive
text-shadow: 0 1px 1px lighten(#313131, 5%);
}

.folder {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 4

@neilkalman-redkix neilkalman-redkix deleted the add-project-circular-avatar branch April 22, 2016 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add circular logo for projects
2 participants