Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

SST26VFxxxB added. #2401

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

serkanxselcuk
Copy link
Contributor

@serkanxselcuk serkanxselcuk commented Dec 23, 2019

SST26VFxxxB added.
Datasheet: http://ww1.microchip.com/downloads/en/DeviceDoc/SST26VF064B-SST26VF064BA-2.5V-3.0V-64-Mbit-Serial-Quad-IO-Flash-Memory-Data-Sheet-DS20005119J.pdf
image

image
image

Footprint PRs:
KiCad/kicad-footprints#2018
KiCad/kicad-footprints#2017
Existing Footprints:
SOIC-16 and SOIJ-8


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@serkanxselcuk
Copy link
Contributor Author

serkanxselcuk commented Dec 23, 2019

image
KLC S4.2
Pins 6,5,2,3 grouped right side as similar function
Pins 1,7 placed to left side as inputs

image
Exception to KLC S4.2
Pin1 could be placed to right side, but it would not be pin compatible with other symbols.

Travis/CI errors
Footprint PRs:
KiCad/kicad-footprints#2018
KiCad/kicad-footprints#2017

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Dec 23, 2019
@cpresser
Copy link
Contributor

cpresser commented Jan 8, 2020

Hi,
thanks for your contribution.
Can you elaborate why you did distribute the pins the way you did? I am asking because we already have a few different layouts for QSPI chips in the library, this PR would add another one.

image
image

@serkanxselcuk
Copy link
Contributor Author

serkanxselcuk commented Jan 13, 2020

Hi,
thanks for your contribution.
Can you elaborate why you did distribute the pins the way you did? I am asking because we already have a few different layouts for QSPI chips in the library, this PR would add another one.

Hi @cpresser ,
There was no KLC or common usage for QSPI as I know. I am not sure, if it is the best solution to place CLK pin at left side, just because it is an input.

[option 1: as is]
I find it better to place all pins for a bus system as neighbor pins. This why I preferred to set all SPI pins at one side. The other pin which is not used for SPI but QSPI (SIO3) at other side to get symbol smaller.

[option 2: I would prefer]
Actually I would prefer to set SIO0-3, CLK and CE pins at left side, so all pins with QSPI or SPI bus wires can be placed together. But it would cost of size in Y direction. (Left side because it is a slave device)

image

I understand KLC input at left, output at right for motor controller (microcontroller communication at left, motor outputs at right) or dc-dc converter (Vin at left, Vout at right) as like adc (analog input at left, digital output at right). But not forcing all pins defined as input at left, output at right.

[option 3]
Symbol W25Q32 placed all input defined pins at left side, others at right side.

[option 4]
Symbol AT25SF081 placed all input defined pins at SPI mode at left side, output defined pins at SPI mode at right side.

IMO, these are slave devices, which controlled by a microcontroller. input serves a microcontroller (master), which can read values back and there is no output device connected.

EDIT:
As like we cannot separate RX/TX in UART or SCL/SDA in I²C; I would place SPI and QSPI pins together at one side. Because of that, I would prefer option 2.

Thank you for your spent time. Can you please answer your opinion?

@cpresser
Copy link
Contributor

Hi @serkanxselcuk,
thanks for your detailed answer.

As like we cannot separate RX/TX in UART or SCL/SDA in I²C; I would place SPI and QSPI pins together at one side. Because of that, I would prefer option 2.

Yes. KLC explicitly states that pins with similar function should be grouped. All of those pins are QSPI, so they can be on one side.
It introduces a new style, but I think it is superior compared to the existing ones. So lets continue with that.

As a side-note, I think the existing spi flash memory symbols should be reworked to conform to s
the same standard.

@cpresser cpresser added Pending footprint Pending footprint acceptance before merging and removed Pending reviewer A pull request waiting for a reviewer labels Jan 15, 2020
@cpresser cpresser self-assigned this Jan 15, 2020
@serkanxselcuk
Copy link
Contributor Author

Hi @cpresser,
I grouped QSPI pins, like we spoken before.
image

@cpresser
Copy link
Contributor

@serkanxselcuk Sorry I am really busy with other stuff right now. Our Hackerspace is moving within the next two weeks.

@cpresser
Copy link
Contributor

This took really long, thanks for your patience.

  • PinNumbers: The SO part has VSS on Pin 10.
  • PinTypes: SIO3 should be bidir
  • PinNames the datasheet has some places where 'HOLD' is not shown as inverted/active-low. but according to Figure 4-3 it is inverted.
  • Pin Positions
  • Naming: The operating frequency and temperature-variant are missing from the name. Please add -xxxx to the names before the package-suffix. Both need to be wildcarded. And we can't omit this part because it is not at the end of the name (KLC S2.2)

Related Footprint-PR:
KiCad/kicad-footprints#2018

@cpresser cpresser added the Pending changes User is expected to perform fixes before merging label Mar 15, 2020
@cpresser
Copy link
Contributor

Hi @serkanxselcuk are you still active with this PR? If not, I would like to mark this and the related footprint PR as abandoned.

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Sep 22, 2020
@myfreescalewebpage myfreescalewebpage removed Abandoned Original author has stopped working on the PR Pending footprint Pending footprint acceptance before merging labels Sep 29, 2020
@myfreescalewebpage
Copy link
Collaborator

@cpresser fp has been merged for this symbol

@myfreescalewebpage
Copy link
Collaborator

@serkanxselcuk seems the fp need to be updated in the symbol following run of travis

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library Pending changes User is expected to perform fixes before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants