[DebugInfo] Add Target Function optional parameter to DebugFunction #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's being added in KhronosGroup/SPIRV-Registry#186 In DWARF it's used in 'trampoline' functions generated for external function calls. Signed-off-by: Sidorov, Dmitry <[email protected]>
|
@vmaksimo please take a look |
vmaksimo
reviewed
Feb 22, 2023
lib/SPIRV/SPIRVToLLVMDbgTran.cpp
Outdated
| DIS = Builder.createFunction(Scope, Name, LinkageName, File, LineNo, Ty, | ||
| ScopeLine, Flags, SPFlags, TParamsArray, FD); | ||
| ScopeLine, Flags, SPFlags, TParamsArray, FD, | ||
| nullptr, nullptr, TargetFunction); |
There was a problem hiding this comment.
Maybe would be nice to left comments about what nullptr means
There was a problem hiding this comment.
Sure, I'll add it!
There was a problem hiding this comment.
Added, but please don't ask me, what these parameters mean :D
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
vmaksimo
approved these changes
Feb 23, 2023
stanleygambarin
pushed a commit
to stanleygambarin/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 30, 2023
… DebugFunction (KhronosGroup#1853) It's being added in KhronosGroup/SPIRV-Registry#186 In DWARF it's used in 'trampoline' functions generated for Fortran external function calls.
stanleygambarin
pushed a commit
to stanleygambarin/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 30, 2023
… DebugFunction (KhronosGroup#1853) It's being added in KhronosGroup/SPIRV-Registry#186 In DWARF it's used in 'trampoline' functions generated for Fortran external function calls.
MrSidims
added a commit
that referenced
this pull request
Mar 31, 2023
… DebugFunction (#1853) It's being added in KhronosGroup/SPIRV-Registry#186 In DWARF it's used in 'trampoline' functions generated for Fortran external function calls.
MrSidims
added a commit
that referenced
this pull request
Apr 3, 2023
… DebugFunction (#1853) It's being added in KhronosGroup/SPIRV-Registry#186 In DWARF it's used in 'trampoline' functions generated for Fortran external function calls.
mateuszchudyk
pushed a commit
to mateuszchudyk/SPIRV-LLVM-Translator
that referenced
this pull request
May 10, 2023
… DebugFunction (KhronosGroup#1853) It's being added in KhronosGroup/SPIRV-Registry#186 In DWARF it's used in 'trampoline' functions generated for Fortran external function calls.
mateuszchudyk
pushed a commit
to mateuszchudyk/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 29, 2023
… DebugFunction (KhronosGroup#1853) It's being added in KhronosGroup/SPIRV-Registry#186 In DWARF it's used in 'trampoline' functions generated for Fortran external function calls.
MrSidims
added a commit
that referenced
this pull request
Oct 5, 2023
… DebugFunction (#1853) It's being added in KhronosGroup/SPIRV-Registry#186 In DWARF it's used in 'trampoline' functions generated for Fortran external function calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's being added in
KhronosGroup/SPIRV-Registry#186
In DWARF it's used in 'trampoline' functions generated for Fortran external function calls.