bugfix nan test for basic fpmath #2268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bashbaug
requested changes
Feb 10, 2025
zzk0
force-pushed
the
bugfix_basic_fpmath
branch
from
bc9c1cb to
5715850
Compare
zzk0
force-pushed
the
bugfix_basic_fpmath
branch
from
5715850 to
46bfd41
Compare
bashbaug
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Note, at least on my system, both_nan is never true. I think this is because the inputs for these test cases are chosen so NaNs will not occur. So, I still think we could remove all of this NaN handling if we'd like.... or we could keep it as it is here, just in case it becomes needed in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the validation logic for cases where the data type is not half. Because the variable nan_test is always false, types like float never trigger a validation failure.