Deduplicate create_image from Copy/Fill image tests #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelRizkalla-arm
force-pushed
the
deduplicate_image_create
branch
from
3f0d541 to
1ce4144
Compare
1. Remove duplicate `create_image` code that is shared between clFillImage and clCopyImage test directories. 2. Unify how pitch buffer's memory is deallocated; The buffer can be allocated with either `malloc` or `align_malloc` and the free function is pre-set in `pitch_buffe_data`'s member variable `free_fn` and used when the buffer is deallocated. With this, the change removes `is_aligned` conditional variable that was used to select the appropriate free function. Signed-off-by: Michael Rizkalla <[email protected]>
MichaelRizkalla-arm
force-pushed
the
deduplicate_image_create
branch
from
1ce4144 to
1d760b1
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_imagecode that is in both clFillImage and clCopyImage test directories.mallocoralign_mallocand the free function is pre-set inpitch_buffe_data's member variablefree_fnand used when the buffer is deallocated. With this, the change removesis_alignedconditional variable that was used to select the appropriate free function.