Fix Build Warnings for AArch64 #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This commit links to issue (KhronosGroup#2234). When cross-compiling for AArch64, using gcc 13.3, you encounter three warnings types that turn into errors: - maybe-uninitialized - stringop-truncation - strict-aliasing This commit fixes all the warnings found, in regards to the first two rules. To resolve the warnigns due to strict-aliasing, I am editing the CMake build system. Signed-off-by: Antonios Christidis <[email protected]>
Antonios-C
force-pushed
the
crossCompilerWarnings
branch
from
50c69d4 to
e31460e
Compare
svenvh
reviewed
Jan 23, 2025
Remove the default case, so it will be possible to catch compiler errors when the enum is extended. Signed-off-by: Antonios Christidis <[email protected]>
svenvh
approved these changes
Jan 24, 2025
|
@svenvh What is the process for getting pull requests merged after they have been approved ? |
|
These fixes should be uncontroversial; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit links to issue (#2234).
When cross-compiling for AArch64, using gcc 13.3, you encounter three warnings types that turn into errors:
This commit fixes all the warnings found, in regards to the first two rules. To resolve the warnigns due to strict-aliasing, I am editing the CMake build system.
Signed-off-by: Antonios Christidis [email protected]