Separately track bitarray capacity #2349
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where when resizing from > 64 bits to ≤ 64 bits, BitArray wouldn't realize that it was going to go from interpreting _data as a pointer to interpreting it as bits, and would fail to both free the pointer and copy its contents into _data, resulting in a memory leak, loss of the data in the BitArray, and a desync with the
_lowestNeverClearedBitIndex
and_clearedSectionCount
variables. In the worst case scenario, such a resize when_lowestNeverClearedBitIndex
was 0 would make future calls tosetAllBits
not set all bits, even though many bits were not set.